OH-SHOWN / ohshown-backend

OH!SHOWN 野生動物出沒痕跡通報系統
http://ohshown.site
MIT License
2 stars 8 forks source link

When creating creatures, fields could be none #90

Open tai271828 opened 1 year ago

tai271828 commented 1 year ago

Or we will get:

web_1     |   File "/usr/local/lib/python3.7/site-packages/rest_framework/views.py", line 492, in dispatch
web_1     |     response = handler(request, *args, **kwargs)
web_1     |   File "/usr/local/lib/python3.7/site-packages/rest_framework/decorators.py", line 55, in handler
web_1     |     return func(*args, **kwargs)
web_1     |   File "/Disfactory/api/views/factories_cr.py", line 239, in get_nearby_or_create_ohshown_events
web_1     |     return _handle_create_ohshown_events(request)
web_1     |   File "/Disfactory/api/views/factories_cr.py", line 126, in _handle_create_ohshown_events
web_1     |     "maturity": creature["bearType"],
web_1     | KeyError: 'bearType'
web_1     | "POST /api/ohshown-events HTTP/1.1" 500 16854

Solution: change this part in factories_cr.py:

        for creature in post_body["bears"]:
            new_creature_field = {
                "maturity": creature["bearType"],
                "size": creature["bearSize"],
                "gender": creature["bearSex"],
                "display_number": num_creature_max + cnt,
            }