search

OHDSI / Atlas

ATLAS is an open source software tool for researchers to conduct scientific analyses on standardized observational data
http://atlas-demo.ohdsi.org/
Apache License 2.0
266 stars 136 forks source link

Highlight differences in JSON between versions of the same cohort #2729

Open gowthamrao opened 2 years ago

gowthamrao commented 2 years ago

Expected behavior

We currently have versioning of cohort definitions. We dont have a way to compare them It would be nice to have a compare feature similar to git compare. Compare the JSON and also SQL if possible.

Actual behavior

No such features currently exist. I can download json of each version - and compare them locally.

Justification

Many times we collaborate on cohort building. Another person might check/modify/improve a cohort i had created. This would be nice to see if the change was small (e.g. changed a unit, or added a conceptId to a concept set).

chrisknoll commented 1 year ago

It would be difficult to implement this in the tool, you're basically asking for a winmerge visualization (left-side, right side) comparison of the cohort entry which is a complicated feature to implement. There may be diff-tool javascript libraries that we can leverage for this, but I don't think we can write this from scratch when you could export the JSON/SQL and leverage third-party tools to do the compare.