search

OHDSI / FeatureExtraction

An R package for generating features (covariates) for a cohort using data in the Common Data Model.
http://ohdsi.github.io/FeatureExtraction/
60 stars 58 forks source link

Update custom covariate builder vignette #259

Closed ginberg closed 4 months ago

ginberg commented 4 months ago

hi @schuemie, I have updated the vignette with regard to the extra parameter. The extra parameter is not actually used since aggregation is not supported in getDbLooCovariateData but I don't think that's a problem? see #258

schuemie commented 4 months ago

I think this looks good, but maybe add a comment that this only applies to aggregated covariates? (And perhaps also that that is why it is not implemented in the vignette example)

ginberg commented 4 months ago

@schuemie yes I think that's a good idea. I have updated the documentation for the argument, what do you think about it?

schuemie commented 4 months ago

Looks good! Thanks!