search

OLSR / olsrd

OLSR.org main repository - olsrd v1 - maintained by Freifunk Berlin
Other
84 stars 65 forks source link

Revert "pud: fix build with gpsd >= 3.23.1" #109

Closed ffontaine closed 3 years ago

ffontaine commented 3 years ago

This reverts commit 69ae23be9f96b9e7dd68a0252f3ad05986bb222d. Indeed, here is an extract of https://gpsd.gitlab.io/gpsd/gpsd_json.html:

The optional "status" field (aka fix type), is a modifier (adjective) to mode. It is not a replacement for, or superset of, the "mode" field. It is almost, but not quite, the same as the NMEA 4.x xxGGA GPS Quality Indicator Values. Many GNSS receivers do not supply it. Those that do interpret the specification in various incompatible ways.

So from my understanding, status field is optional and STATUS_NO_FIX has been explicitly renamed into STATUS_UNK to avoid confusion with MODE_NO_FIX (which is already handled by gpsdclient.c). I would advise to drop the if block to really fix the build failure.

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

PolynomialDivision commented 3 years ago

I also thought about it, so lets merge it. :)

PolynomialDivision commented 3 years ago

Can you maybe further try fixing it?