search

OLSR / olsrd

OLSR.org main repository - olsrd v1 - maintained by Freifunk Berlin
Other
84 stars 65 forks source link

lib/pud: fix build with gpsd >= 3.25 #122

Closed yann-morin-1998 closed 1 month ago

yann-morin-1998 commented 1 year ago

Fix build against gpsd-3.25.

Fixes: #118 Supersedes: #119 #120 #121

This was tested to fix the build with gpsd-3.25, as detected by Buildroot autobuilders: http://autobuild.buildroot.org/results/47a619686bb47debd525c92aa7e14bee5c40ca9e

yann-morin-1998 commented 1 year ago

@mathiashro As requested in #120, here's a respin of the gpsd 3.25 fix, with a revert of #119.

yann-morin-1998 commented 1 year ago

@mathiashro Do you have any feedback to provide, please?

Currently, the build is broken with versions of gpsd older than 3.25, which are still present in some LTS distributions like Debian and derivatives, which only has 3.22 packaged so far.

PolynomialDivision commented 1 year ago

This does not seem correct. The major version was already bumped for v23: https://gitlab.com/gpsd/gpsd/-/commit/0df348fe5f18bfeb2c4a6a20172ffda9bf0b1a43

However, the fixsource_t was changed in v24: https://gitlab.com/gpsd/gpsd/-/commit/35fe48835da07cb1045e404aef0a582c04fd8da1

So v23 will not build with this change here?