OLSR / olsrd

OLSR.org main repository - olsrd v1 - maintained by Freifunk Berlin
Other
84 stars 65 forks source link

pud: adapt to API changes in gpsd 3.20 #79

Closed cotequeiroz closed 4 years ago

cotequeiroz commented 4 years ago

The timestamp fields were changed from double to struct timespec, and the geoid separation field was moved to fix.geoid_sep.

Signed-off-by: Eneas U de Queiroz cotequeiroz@gmail.com

This is a quick patch to let it compile. I can't run-test this, I've just compile-tested in using openwrt master, with gpsd 3.20 and 3.19, for a mvebu/arm_cortex-a9 target.

PolynomialDivision commented 4 years ago

Why is this PR still not merged?

vchrizz commented 4 years ago

As I understand the OLSRd(v1) project does not have any maintainer. See: https://lists.olsr.org/pipermail/olsr-dev/2020-February/008465.html New maintainer applications are welcome.

Originally posted by @mathiashro in https://github.com/OLSR/olsrd/pull/81#issuecomment-614138560

HRogge commented 4 years ago

Why is this PR still not merged?

Do you want to become the OLSRv1 maintainer?

booo commented 4 years ago

@HRogge If you like you can add me as maintainer and I will do my best to handle the sporadic fixes that people contribute. We still use OLSRv1 in the Berlin Freifunk Community and have a great interest in working code.

Are there any do's and don't as a olsr maintainer?

HRogge commented 4 years ago

I would guess it doesn't make sense to force lots of do's/don'ts on the only maintainer... we can talk about it if you want to set some rules of your own.

Congratulation, you just revived the olsrd(v1) project.

mathiashro commented 4 years ago

@booo & @HRogge, I would also support together with our Freifunk Rostock Community. I've you don't mind you can add me as well / as co-maintainer.

booo commented 4 years ago

@booo & @HRogge, I would also support together with our Freifunk Rostock Community. I've you don't mind you can add me as well / as co-maintainer.

That would be great!

I would guess it doesn't make sense to force lots of do's/don'ts on the only maintainer... we can talk about it if you want to set some rules of your own.

I just asked so we don't hurt anybodies feels. I agree we don't need (a lot of) rules right now. We can trust the common sense for now :)

fhuberts commented 4 years ago

If you want I can help get you setup and explain what I did as maintainer. Email me if you like, so we can setup chats etc. Email should be in all of my commits.

booo commented 4 years ago

I compiled the change on my archlinux machine with gpsd version 3.20-1 and it worked fine. I merged your changes into master and I'm closing this issue now.

zorun commented 4 years ago

You might want to change that scary "v1 IS IN HARD FREEZE AND NO LONGER MAINTAINED" in the project description :)