bmf: change include from sys/poll.h to poll.h

OLSR / olsrd

OLSR.org main repository - olsrd v1 - maintained by Freifunk Berlin

Other

84 stars 65 forks source link

bmf: change include from sys/poll.h to poll.h #95

Closed PolynomialDivision closed 3 years ago

PolynomialDivision commented 3 years ago

Musl library generates an error when including <sys/poll.h>. POSIX specifications state that should be used.

Fixes warnings in the form of:

  [CC] src/Bmf.c
  In file included from src/Bmf.c:70:
  /home/nick/openwrt/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl
     /include/sys/poll.h:1:2: warning: #warning redirecting incorrect
     #include <sys/poll.h> to <poll.h> [-Wcpp]
   #warning redirecting incorrect #include <sys/poll.h> to <poll.h>

PolynomialDivision commented 3 years ago

@fhuberts Why did you decide to go for <sys/poll.h>?

fhuberts commented 3 years ago

I'd advise to use gitk to see where that change came from, or git blame. Then you'll see that it comes from here:

1104d182431f95ad96b027b9277e47555357dffc Author: Henning Rogge hrogge@googlemail.com 2010-03-23 12:56:06 Committer: Henning Rogge hrogge@googlemail.com 2010-03-23 12:56:06

PolynomialDivision commented 3 years ago

I'd advise to use gitk to see where that change came from, or git blame. Then you'll see that it comes from here:

1104d18 Author: Henning Rogge hrogge@googlemail.com 2010-03-23 12:56:06 Committer: Henning Rogge hrogge@googlemail.com 2010-03-23 12:56:06

Thanks. So there is no reason to include it like that. :)