ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
8 stars 215 forks source link

DTDC - LSP - compliance check #1489

Open abhinavv245 opened 2 months ago

abhinavv245 commented 2 months ago

Forward Flow

/search

/on_search

/init

/on_init

/confirm

/on_confirm

/on_update (missing)

/on_status

RTO Flow

/update

/on_status

/on_cancel

/on_status

Cancellation flow

/on_cancel

@aditya-sharma2-shipsy

abhinavv245 commented 2 months ago

Flow 1

/on_update

/on_status (out for delivery)

Cancellation Flow

/on_cancel

/on_status(unsolcited)

RTO Flow

/on_cancel

Kindly use the log verification tool to verify at your end and make sure all the previous issues are resolved before resubmitting the logs

@aditya-sharma2-shipsy

aditya-sharma2-shipsy commented 2 months ago

Flow 1

/on_update

/on_status (out for delivery)

Cancellation Flow

/on_cancel

/on_status(unsolcited)

RTO Flow

/on_cancel

@abhinavv245 request your help on the four points Q1, Q2, Q3 and Q4 so we can make the changes accordingly and re-create the logs

abhinavv245 commented 2 months ago

@aditya-sharma2-shipsy

abhinavv245 commented 1 month ago

All Flows

/on_cancel

/on_status

/on_update

Is tracking supported by DTDC? In case yes, then track/on_track to be provided (url based tracking), else fulfillments/tracking value should be false in all APIs starting /on_confirm

Note: Please run the log verification tool before submitting logs

@aditya-sharma2-shipsy

aditya-sharma2-shipsy commented 1 month ago

/ on_cancel :

/on_status :

/on_update:

We do provide tracking that was a miss from our end in the logs

@abhinavv245 request your response for these 3 points Q1, Q2 and Q3

abhinavv245 commented 1 month ago

@aditya-sharma2-shipsy

BLR-0118 commented 1 month ago

@aditya-sharma2-shipsy:

aditya-sharma2-shipsy commented 1 month ago

@BLR-0118 Thank you for your inputs

BLR-0118 commented 2 weeks ago

Forward Flow

  1. average pickup time (fulfillment.start.time.duration) wasn't provided by LSP in /on_search (ok) but LBNP quoted 24 hrs for this in /confirm which was accepted by LSP (as it's part of /on_confirm): why?
  2. LBNP is sending pickup & delivery code type for OTP, with incorrect details ("authorization" not provided) & without requesting for pickup/delivery authorization (using OTP) in /search; how's this being processed?
  3. LSP quoted S2D TAT of 2 days but status request was sent after 6 days and order was actually delivered after 6 days: why?
  4. tracking is enabled & /on_track response provided; however, "tracking"."url_enabled" and "url" aren't enabled in /on_status to notify buyer app;
  5. are all fulfillment states defined here supported?
BLR-0118 commented 2 weeks ago

RTO flow

  1. /on_cancel (unsolicited) seems correct but /on_status (unsolicited RTO initiated) is wrong as it's not showing the latest copy of the order as shown in /on_cancel, e.g.: a. cancelled_by should have the bpp_id; b. precancel_state and rto_event are missing;
BLR-0118 commented 2 weeks ago

@aditya-sharma2-shipsy - pls fix & resubmit;

aditya-sharma2-shipsy commented 1 week ago

@BLR-0118

Forward Flow :

  1. will fix this
  2. we have not integrated the pickup and delivery otp change as it is part of phase 2, this was passed back in on_confirm as we just picked up the instructions that we received in confirm and passed in on_confirm We can do this that we validate and not directly pass the instructions if it's not relevant field as per phase1, but we cannot throw an error based on this field.
  3. Actually there were availability delay from LBNP end thus there was delay in creating logs thus there was a delay
  4. this is a optional field as mentioned in contract, that is why we have not passed this
  5. Not all fulfillments are supported, We support below fulfillments: "Pending" "Searching-for-Agent" "Agent-assigned" "Order-picked-up" "At-destination-hub" "Out-for-delivery" "Order-delivered" "Cancelled"

Request for your views on these points.