Open Jagannath-wits opened 2 months ago
timing.type
as all
.bpp/providers.tags.veg_nonveg
is invalid and isn’t provided at the provider level. Please refer to the contract.@ondc/org/statutory_reqs_prepackaged_food
and @ondc/org/statutory_reqs_packaged_commodities
not done properly. Please refer to sheet.items.tags.veg_nonveg
is optional, only as applicable. Please refer to contract.@ondc/org/return_window
should be realistic and feasible.on_search_full_catalogue
and inc_on_search
, and also location is not captured properly.payment.tags.bpp_collect
is only required when BPP is collecting payment.@ondc/org/buyer_app_finder_fee_type
, @ondc/org/buyer_app_finder_fee_amount
, and @ondc/org/settlement_details
are required in payment object when the buyer is collecting money.on_init
and carried forward. If only BAP is collecting, then "collected by" should be BAP in Confirm
as provided, and the rest will be the same as currently provided.Tags.bpp_terms
: Only tax_number
, np_type
, and provider_tax_number
are required; others are not enabled yet, so please remove the others.on-confirm
unless the order is accepted. Also, the instructions are invalid as you have only selected delivery fulfillment.@ondc/org/provider_name
changed compared to on_confirm
; there won’t be any change in fulfillment details.end.address
has updated compared to on_confirm
, which shouldn't happen.on_select_oos
not implemented correctly. Multiple items should be collected as defined in the rollout plan.messsage.order.error
is missing, please refer to contract.32041007-19f4-42dc-8a25-bf153c9e12ae
is not reduced or out-of-stock.32041007-19f4-42dc-8a25-bf153c9e12ae
available again when it's supposed to be out of stock in on_select_oos
?order.state
created in Flow 2 and accepted in Flow 4? If the order is accepted, routing should be provided.reason_code
used as in Flow 4, the order is cancelled pre-shipment. Please refer to reason codes sheet.32041007-19f4-42dc-8a25-bf153c9e12ae
is 0.quote.price
should be 0 as the order is cancelled pre-shipment.igm_request
is only required when an igm_request
has been actually raised.precancel_state
has not been captured correctly as Flow 4 order is cancelled pre-shipment. How can precancel state be Order-picked-up
?precancel_state
has not been captured correctly as Flow 5 order is cancelled after its shipment. How can precancel state be Order-picked-up
? It should be out-for-delivery
.on_status_rto_delivered
is required after on_cancel_RTO
where the end.timestamp
of RTO fulfillment will be updated.on_update_part_cancel
sent before order is accepted?@krishna-balasubramanyam-2020 - Please fix all issues before next submission - Please submit the utility payload in the repo for each flow.
Please provide atleast 5 items in catalogue. the provider only supports delivery fulfillment so why is there self-pickup in bpp/fulfillments ? How is the timestamp of catalogue being updated? It should be updated whenever there is a change at that level i.e eg: if there is a change at item level then it’s timestamp should update and not at each on_search invalid ean code used image url should be accessible. Eg: https://snaporder-v2.sgp1.digitaloceanspaces.com/uploads/banners/default-banner.jpg
How are you getting time.range for start and end before order is accepted? Time.range for start and end should be calculated accurately, how come the the start of range for both pickup and delivery be same as context.timestamp tracking status cant change in on_confirm as tracking was not supported in on_select
@ondc/org/TAT changed from 3H to 60M; it should remain same how did delivery charges get 0 in on_status?
fulfillment.start.time.timestamp is updated at on_status_picked when order is picked and not before that.
incorrect payload, please refer to contract and run utility before submission
The count remained the same and didn’t change comapared with select_oos
Same item which was supposed to be out of stock is selected
The count remained same here too.
fulfillment 43271e58-a44c-4272-a6ab-39b15c6d2b7f doesn’t exist in on_cancel i.e not carried forward. incorrect payload, please refer to contract and run utility before submission.
same as above
Please run utility and fix errors before resubmission
Variants are not captured properly @ondc/org/statutory_reqs_prepackaged_food is not required for the category_id : ‘Tea and Coffee’, ‘Masala & Seasoning’, ‘Oil & Ghee’ and ‘Rice and Rice Products’
If the time is less than or equal to 2H, then it should be treated as ‘Immediate Delivery’
precancel_state.fulfillment_state of on_cancel is not equal with the on_confirm fulfillment state
Tags are not allowed in the items
@krishna-balasubramanyam-2020
@sahil-ondc Further update done and committed here - https://github.com/ONDC-Official/v1.2.0-logs/pull/2230
@krishna-balasubramanyam-2020 Please resubmit the logs with complete payload for flow 6 and 5. Currently on_status_rto_delivered in flow 5 and the entire flow of reverseQC and/or Liquidated is missing as mentioned in previous iterations.
@Jagannath-wits precancel_state.fulfillment_state of on_cancel is not equal with the on_confirm fulfillment state So it is supposed to be pending.
But in log validator, it's asking for out-for-delivery state for precancel_state.fulfillment_state. Plz clarify!
We are not handling reverseQC flow as we only ask for Liquidated/settlement. ie All our merchant requirements is that we don't accept returns. We had already been fulfilling several orders in v1.1. with just Liquidated.
on_status_rto_delivered flow, I had asked our team to submit.
Is it possible to reach out to anyone in your team over Whatsapp to clarify or discuss some of the final points and clear this?
@Jagannath-wits precancel_state.fulfillment_state of on_cancel is not equal with the on_confirm fulfillment state So it is supposed to be pending.
But in log validator, it's asking for out-for-delivery state for precancel_state.fulfillment_state. Plz clarify!
- It will be out-for-delivery only
We are not handling reverseQC flow as we only ask for Liquidated/settlement. ie All our merchant requirements is that we don't accept returns. We had already been fulfilling several orders in v1.1. with just Liquidated.
- Please get an exceptional approval for the same.
on_status_rto_delivered flow, I had asked our team to submit.
- If you support liquidation then why is the liquidation flow also missing in flow 6 ?
Is it possible to reach out to anyone in your team over Whatsapp to clarify or discuss some of the final points and clear this?
- You can reach out to tech support team or drop a mail for the same
@krishna-balasubramanyam-2020
@Jagannath-wits Thanks for the comments.
We already got approval for the same. Our team will submit the liquidation flow also.
Pinky Rawat called to clarify and help. Thanks.
@Jagannath-wits Did the log validator go through further update? We are getting errors like "schemaErr0": "/message/order/fulfillments/1/tags/0/code must be equal to one of the allowed values (quote_trail)",
But the log validator didn't have it previously. Also we do have allowed values only "quote_trail"
Similarly, we have errors that were not previously.
What should we do?
statutory_reqs_packaged_commodities
, the value should either be the information about the product (if available), "NA" (if info not available), or "refer to back image" with the image URL provided in item.tags.back_image
.on_search_inc
; there are no changes in bpp_providers.descriptor
.bpp_providers.tags
updates cannot be provided in on_search_inc
.pickup
and delivery
time.range calculated dynamically?email
in delivery.end.person
.Please run utility before submission.
Order.items
object not captured correctly.return_request
not carried forward from update liquidated
. Trail must be maintained.return_request
not carried forward from update liquidated
. Trail must be maintained.Order.items
object not captured properly; please check item ef751f3f-462d-4119-99da-e38eedb96b33
.e26317a0-7125-4d3c-97ab-7400597649b8
) not mapped with item in order.items
.order.item
the same for part-canceled and liquidated items?update_settlement
is received? Please explain how this was handled.@krishna-balasubramanyam-2020
@Jagannath-wits Some of the questions from our previous comments where not addressed.
Many of these comments are coming up newly and more questions are being asked. So can we get on a call?
Also some comments are invalid like: Invoice is inaccessible. We can access from incognito also => https://snapmerchant-preprod.snapbizz.com/invoice/2024-08-13-237892 It takes about 1 or 2 seconds to load.
Is there a reference seller app logs that we can refer? I had asked for a reference multiple times now. But no reply.
Also utility logs - New errors are coming up that were passed earlier. (I asked this question in previous comment) Not sure if there are issues with utility logs! Or some parts are broken!
Shall we get on a call to discuss the questions from both sides? Because the review and submit and question/answers cycle is taking too long. Our team is available to get to Prod as soon as possible.
Our intent is to close this soon given it's already been 4 or 5 iterations.
@krishna-balasubramanyam-2020, There seems some manual manipulation in submitted logs, can you please share Pramaan reports along with logs.
@krishna-balasubramanyam-2020
@krishna-balasubramanyam-2020
on-search
inc_on_search
on_status out for delivery
/on_confirm
/on_cancel
/on_status
@krishna-balasubramanyam-2020
Flow 1
On_search_full_catalog
parent_item_id
should be mapped with variants.categories.tags
will not have serviceability. Why is it there? Please stick to the contract and in case of doubts please reach out to tech support or ask here."category_id": “Stationery”
is now moved toret16
. Please refer to sheet."@ondc/org/fssai_license_no": “”
is not required forret10
. Please refer to contract as it also has examples and scenarios.descriptor.code
,description
,urls
, etc.bpp/provider.tags
not captured correctly and completely incorrect. For example, why is the object with"code": “Grocery”
? Timing object is not captured correctly. Please refer to contract and strictly stick to it.Flow 2
on_confirm
on_status_pending
on_status_picked
Flow 3
Flow 5
Flow 6
settlement details have not been carried forward Invoice should be updated after part-cancel Quote trail has not been carried forward or captured properly
@krishna-balasubramanyam-2020 Please refer to contract and not just utility.