ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 287 forks source link

Futuresoft (SA: RET10) - compliance check #2058

Closed sahil-ondc closed 2 weeks ago

sahil-ondc commented 4 months ago

Flow 1

On_search

There should be at least 2 items linked with the associated variant for it to be called a variant.

Flow 2

On_select

quote.breakup.item.tags type item is not required for standalone SKUs.

On_init

Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount, and @ondc/org/settlement_details are required in the payment object when the buyer is collecting money. Currently, only the buyer is collecting money on the network.

On_status

@ondc/org/time_to_ship should be reasonable and calculated so the pickup range is accurate. For example, if time_to_ship is 3 days, but the pickup range is only 2 hours.

Flow 5

On_status_rto_delivered

Payload missing (terminal state for on_cancel_rto should be provided). on_status_rto_delivered is required after on_cancel_RTO where the end.timestamp of RTO fulfillment will be updated.

Flow 6

On_status_picked

Invoice not updated after part-cancel.

On_update_approval

return_fulfillment.end.time and range are not required in on_update_approval. Please refer to the contract.

@Geeta

sahil-ondc commented 2 months ago

Flow 5

On Cancel

Flow 6

On Update Liquidated

sahil-ondc commented 3 weeks ago

Flow-1

On_search-

@geeta

fsgithub2024 commented 3 weeks ago

Flow-1

On_search-

  • Invalid EAN code for item with id 46069368881407, please check for others.

Are you highlighting the item's descriptor code?

  • invalid item_id format- gid://shopify/ProductVariant/46069366653183. It should be either uuid or 32 characters long - - alphanumeric without any special characters

Would like to inform you previous logs has been verified with the above mentioned product id. It is Shopify Id which we are passing.

@sahil-ondc

shivang1131 commented 2 weeks ago

Flow 1

on_Search

Flow 2

@fsgithub2024

fsgithub2024 commented 2 weeks ago

Flow 1

on_Search

  • Timing cannot be 0000 to 2359 when store is open from 8 to 5.

Our store operates 24 hours, so this is not an issue.

  • There should be at least 2 items linked with the associated variant for it to be called a variant.

We have 3 items linked with the associated variant for the product "Organic Oranges". However, 2 items are out of stock, which is why they are not displayed.

Flow 2

  • Invoice is not accessible for any of the further flows. We have already cleared the RET12 logs. As per the discussion with ONDC, only Flow 1 requires domain log clearance, so we can ignore this issue for now.

Next Steps: Since the issues mentioned are either not applicable or have been resolved, can we move forward to QA?

@shivang1131

sandeepshahi commented 2 weeks ago

Logs approved for RET 10 v1.2 (subject to above fixes)

@fsgithub2024

fsgithub2024 commented 2 weeks ago

@sandeepshahi The above issues are fixed. Please share the next step.