Open sandeepshahi opened 7 months ago
@bluecypher Please Clarify..
Below are three Points:
fullement ID for tax, even passing fullment ID utility tool is throwing error.
provider location new format - which is correct? Utility tool is throwing an error and the document is not synced.
Please clarify in case of fruits and veggies category ,product detatils has to be sent or not. This is not mentioned in spec document but asked in review comment
@bluecypher Need your help/clarification on above mentioned points
@RonitKumarSinha
https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=983332432
https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=983332432
https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795
@RonitKumarSinha
Hi @sahil-ondc Once this is merged we can review again. As we discussed yesterday fixes are taken care - https://github.com/ONDC-Official/v1.2.0-logs/pull/983
Flow1: Fixed
Flow2:
on_status (picked) /message/order/fulfillments/0 must have required property '@ondc/org/TAT' - Fixed /message/order/fulfillments/0/start/location/address must have required property 'locality' - Invalid /message/order/fulfillments/0/start/location/address must have required property 'city' - Invalid /message/order/payment/params must have required property 'transaction_id' - Invalid context/transaction_id should same as select context/transaction_id - Invalid /message/order/id in /confirm and /on_status should be same - Invalid
on_status (out-for-delivery) /message/order/tags/bpp_terms/tax_number should be same as provided in provided in /confirm - Invalid only tax_number and provider_tax_number should be provided in /tags/bpp_terms; remove other terms related properties - Invalid but added provider_tax_number too
Flow 3 sucessful select call should be provided - provided
Flow 4 invalid flow provided (flows should be submitted as per the sheet) - invalid as discussed was as per the sheet https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795 order should be cancelled before pickup - invalid
Flow 5 on_status (rto-disposed) Transactional logs should be as per the API contract - Fixed
Flow 6 No comments and communicated logs are good
/message/catalog/bpp/providers/items/descriptor short_desc long_desc and name should have unique values - yes it would be unique string in production Is vairants supported ? - No
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec
@sumit5219
Hi @sahil-ondc , Once this is merged we can review again - https://github.com/ONDC-Official/v1.2.0-logs/pull/1104
Flow 1 Fixed
Flow 2 Fixed
/message/order/provider/locations must be object - v1.1 it was an object and now in v1.2 this has to array of object. The details are provided at top of this issue comment. Marking this as invalid as mentioned earlier too.
Flow 3 Fixed
Flow 4 Fixed
on_cancel - Fixed
Flow 5 Fixed
Flow 6 Fixed
on_update - Fixed
on_update
should be equal to the price as in on_confirm
.@sumit5219
Hi @sahil-ondc , As discussed with @sandeepshahi below valid comments are fixed once this PR is merged please review it https://github.com/ONDC-Official/v1.2.0-logs/pull/1164 again. Also as Flow 2 is the issue at buyer end so submitting the lgos for 4,5,6 flows only.
Flow 4 on_cancel message/order/provider rateable is not a valid field according to api contract - done /message/order/fulfillments/1/start not required for type cancel - done
Flow 5 on_cancel_rto_initiated Pre Cancel is mandatory for on_cancel - done confirm on_confirm context/timestamp for /confirm api cannot be greater than or equal to /on_confirm api - done order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added) - done Flow 6: Reverse QC and Liquidation Reverse QC on_update_interim Transaction logs for /on_update_interim should be provided - was already provided on_update_approval /message/order must have required property 'provider'. - done /message/order/fulfillments/0/start/contact must have required property 'email'. - optional filed as discussed with Sandeep so ignoring this Invalid CancellationID 002 or not allowed for BNP. - invalid as per Sandeep as its frombuyer app as we checked.
on_update_picked /message/order/fulfillments/0/start/contact must have required property 'email'. - invalid as mentioned above update_settlement Transaction logs for /update_settlement should be provided - done Liquidation update Reason ID is not a valid reason ID (buyer app initiated). - invalid as its comes from buyer and same is used at seller on_update_liquidated /message/order must have required property 'provider'. - done Quote trail price and item quote price sum for on_update should be equal to the price as in on_confirm. - done
Buyer selects multiple items (> 1 qty for each item) for checkout (multiple items must be selected) as per the sheet
https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795
@sumit5219
Hi @sahil-ondc Review comments are fixed once https://github.com/ONDC-Official/v1.2.0-logs/pull/1185 is merged please review.
Note: Nearshop doesn't allow merchants to do any partial cancel of any order. So the logs of partial cancellation is not provided. But its present in our roadmap as we develop we will re inititate this cancel logs.
@sumit5219
Hi @sahil-ondc Partial Cancel workflow is implemented and submitted Once https://github.com/ONDC-Official/v1.2.0-logs/pull/1254 is merged please review
Flow 5 - invalid as its RTO disposed flow
Flow 6 - Partial Cancel logs are shared now
@sumit5219
Hi @sahil-ondc , Fixes are done once https://github.com/ONDC-Official/v1.2.0-logs/pull/1271 is merged please review.
@sumit5219
Hi @sahil-once https://github.com/ONDC-Official/v1.2.0-logs/pull/1397 is merged please review
bpp/descriptor/accept_bap_terms: accept_bap_terms is not required in bpp/descriptor/tags for now - invalid as this was never sent on_search invldQuoteTrailPrices - this was fixed earlier as checked its matching with on_confirm price of items with quote_trail for respective items
/on_search
/search (inc)
/on_select
/on_init
/on_confirm
/on_status
/on_track
RTO
rto disposed
/on_update (return)
/on_update (liquidated)
/on_update (reverse qc)
@sumit5219
Hi @sandeepshahi Once https://github.com/ONDC-Official/v1.2.0-logs/pull/1544 is merged please review. Above invalid comments are resolved.
Details here as per the ONDC call and comments - https://docs.google.com/document/d/1GJTN1YxxdEZV1XfA1e2gotfBXvmbZUmvKDYSWzry52k/edit?usp=sharing
Hi @sahil-ondc , issues as mentioned above are fixed. Please review once this PR is merged https://github.com/ONDC-Official/v1.2.0-logs/pull/1582
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.p49oiq6osp4
@sumit5219
Hi @sahil-ondc Please review once this is merged https://github.com/ONDC-Official/v1.2.0-logs/pull/1628
Flow1 Fixed @sandeepshahi has confirmed for Fruits and Vegetables it has to be 5:EAN as it was already sent in same format All URLs were already public, seems the copy of URL was not done proper and pasted over browser while reviewing.
Flow 2 & 3 Fixed
Flow 5 Fixed
Flow 6 Above issues automatically fixed and updated logs
Hi @sandeepshahi , Below is the video demo for incremental search.
https://drive.google.com/drive/folders/19lxGO_xjLfkoImF7TrpORqIL2l2OELsx?usp=sharing
/on_search
/on_search (inc)
/on_select
/on_init
/on_status
/on_track
rto initiated
/on_update (part cancel)
/on_status
/on_update (Return Approved)
@sumit5219, please resubmit logs for Flow 1 and Flow 6
Hi @sandeepshahi , Below is the video demo for incremental search.
- backend service logs which sends in every one minute
- Merchant app updating products price, as soon the update is done in next a minute the on_search is send.
https://drive.google.com/drive/folders/19lxGO_xjLfkoImF7TrpORqIL2l2OELsx?usp=sharing
Sure, will check this
Hi @sandeepshahi , above mentioned issues are fixed please find the PR - https://github.com/ONDC-Official/v1.2.0-logs/pull/1644 Note: As from ondc buyer app no incremental req are coming to us atleast so we have used our buyer app to subscribe to push search subscription.
Flow 6 - order screenshot
/on_status
/on_update (Return Approved)
@sumit5219
- use log validation utility to test the logs before submission
Flow 1
/on_search
/on_search (inc)
FLow 2
/select
/on_select
/on_init
use the log validation utility before submitting the logs
Flow 3
Flow 4
Flow 5
submit the logs as per the test case scenarios
Flow 6
@RonitKumarSinha