Dailybee (logistics-BAP) - compliance check

abhinavv245 commented 1 year ago

Flow 1

multiple schema issues with LSP responses (buyer app should send NACK in such cases)

Flow 2

cancellation flow triggering RTO should be implemented

Note: kindly test with a verified LSP and resubmit the logs

@a-satyateja

a-satyateja commented 1 year ago

@abhinavv245 We have updated the logs according to the suggestions given.

please find and verify the latest logs here: https://github.com/ONDC-Official/verification-logs/pull/1084

abhinavv245 commented 1 year ago

Flow 1

/search

reverse geocoding of store cordinates shows a different area code

/confirm

For P2H2P shipments, PCC code is not required in /confirm as LSP sends a shipping label

/update

update call is either used to update the tag (ready_to_ship = yes) or there is an update in the linked order (why is this triggered as nothing seems to have changed)
person, location, contact are not required in start and end in /fulfillments (refer API contract)

Flow 2

similar issues as Flow 1

@a-satyateja

a-satyateja commented 1 year ago

@abhinavv245 , Reverse geocoding was from MapMyIndia's reversegeo api, it returned the area code very adjacent to the gps location we have used. (it can be an issue with map my india or the gps is at the intersection of the two area codes, 560008 & 560038)

All other issues have been rectified/fixed. Please check the PR : https://github.com/ONDC-Official/verification-logs/pull/1095

abhinavv245 commented 1 year ago

Flow 1 and Flow 2

/confirm

tags/@ondc/org/order_ready_to_ship is a required property in /confirm (can be marked 'no' if the order is not ready to ship)

Flow 2

/on_status

how is RTO initiated when order delivery is not possible as per the cancellation_reason_id (also Order-picked-up,Out-for-delivery states are missing)

@a-satyateja

a-satyateja commented 1 year ago

@abhinavv245 The above-listed issues have been resolved. Please check the updated logs on the PR -> https://github.com/ONDC-Official/verification-logs/pull/1101

abhinavv245 commented 1 year ago

Flow 1

Incorrect Flow as per context/timestamps - (update,on_update,search,on_search,init,on_init,confirm,on_confirm,status,on_status)

/update

context/transaction_id Transaction ID should be same as /init: "35654bda-6d1f-4526-94b4-63e9454bf926"
person, location, contact are not required in start and end in /fulfillments (refer API contract)

/on_update (buyer app should send NACK)

context/transaction_id must be equal to constant (35654bda-6d1f-4526-94b4-63e9454bf926) (buyer app should send NACK)
message/order/id must be equal to constant (2023-09-01-907765) (buyer app should send NACK)
message/order/created_at mismatches in /confirm and /on_update

@a-satyateja

a-satyateja commented 1 year ago

@abhinavv245 There was an issue with two of the log files, they weren't copied over correctly.

Can you please check now? https://github.com/ONDC-Official/verification-logs/pull/1108

abhinavv245 commented 1 year ago

Flow 1 and Flow 2

/confirm and /update

Payload weight mismatches w.r.t provided in /search

@a-satyateja

a-satyateja commented 1 year ago

@abhinavv245

We have updated the rectified logs. Can you please verify, PR -> https://github.com/ONDC-Official/verification-logs/pull/1117

sandeepshahi commented 1 year ago

/search

LSP with lower TAT and P2P fulfillment is recommended for hyperlocal deliveries
LSP with lower callback response time should be procured for optimized cascaded flow
geocoding of delivery gps and pincode is inaccurate in /fulfillment/end/location

/confirm

weight of individual item is not in sync with the entire order weight in /@ondc/org/linked_order

@a-satyateja

a-satyateja commented 1 year ago

@abhinavv245

Please verify the updated logs here: https://github.com/ONDC-Official/verification-logs/pull/1213

abhinavv245 commented 1 year ago

Flow 1

/search

Reverse Geocoding for end failed. Area Code 560038 not matching with 12.932473,77.685230 Lat-Long pair

/update

/updated_at does not match context timestamp - \"2023-10-04T11:29:28.793Z\
/fulfillments/start is required when ready_to_ship = yes for P2P shipments

Flow 2

similar issues as above

/on_status

Pickup timestamp (fulfillments/start/time/timestamp) is required for fulfillment state - Order-picked-up" and "Out-for-delivery'
invalid tags object in fulfillments, should be at order level

/on_cancel

fulfillment state should be 'Cancelled'

@a-satyateja

a-satyateja commented 1 year ago

@abhinavv245

Please verify the updated logistics logs: https://github.com/ONDC-Official/verification-logs/pull/1244

abhinavv245 commented 12 months ago

Flow 1 and 2

/update

/fulfillments/start is required when ready_to_ship = yes for P2P shipments

/on_update

/on_update/0/message/order/fulfillments/0/id mismatch from /init (must be equal to constant (1))

@a-satyateja

a-satyateja commented 12 months ago

@abhinavv245 https://github.com/ONDC-Official/verification-logs/pull/1247

sandeepshahi commented 12 months ago

@BLR-0118, the Dailybee Logistics BAP (v1.1.0) logs seem fine. Pls proceed with your review.

@a-satyateja

ONDC-Official / verification-logs