Open Financial - B2B BPP - compliance check

abhinavv245 commented 4 days ago

Non RFQ Flows

remove empty objects
location/state is not required in context

Flow 1

/on_search

serviceability construct is incorrectly defined, duplicate category object, and either it can be defined for each category (for e.g. RET10-1023), or for all categories, "RET10-*" can be used. Also, the type of serviceability, with values representing Hyperlocal (code: 10), Intercity (code: 11), and Pan-India (code: 12), 13 (GeoJSON)
fulfillments/tracking and state are not required
why are gloves being sent in RET10 (Grocery) catalog
items/descriptor/code - unique code for item which will be in this format - "type:code" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others
items/category_ids should be as per the taxonomy codes
time to ship in g2 tag should be in correct format, PT12 is incorrect

/on_select

how is fulfillments/@ondc/org/TAT": "PT1H25M", when time to ship in on_search is 12 hrs, TAT should be defined for order delivery
item/quantity is not required in quote/breakup

/on_init

fulfillments/state is not required
define cancellation terms for more terminal states
customer is not required in fulfillments/stops

/on_confirm

duplicate bpp_terms tag (Second one is not required)

/on_status

on_status calls are provided but there is not change is fulfillment state (it is always pending), update the same and record correct timestamps for order-picked-up and delivery in stops.

Out of stock flow

similar issues as above
Flow should be completed as per test case scenarios
on_search/0/message/catalog/providers/0/items/0/quantity/maximum/count must be integer",
on_search/0/message/catalog/providers/0/items/0/quantity/minimum/count must be integer",
on_select/0/message/order must have required property 'quote'"
search- CityCode 080 should match the city for the fulfillment end location 683101, 0484"
on_select- Delivery charges should be provided in quote/breakup when fulfillment is 'Serviceable'"

Location non serviceable

similar issues as above
error/type should be 'DOMAIN-ERROR'
quote should not be empty
complete flow to be provided

Note: Is prepaid payment not accepted by SNP? Also, if buyer app wants to collect prepaid payment, will SNP not take those orders? In case you are taking prepaid orders, kindly provide logs for those flows as well.

Also, just add the new logs in the same folder, remove the old ones.

@asif0777

asif0777 commented 3 days ago

@abhinavv245 Issue mentioned were fixed and raised the PR again.

why are gloves being sent in RET10 (Grocery) catalog ?

Added this as dummy product for testing. Changes this in this flow.

Is prepaid payment not accepted by SNP?
- Currently not

abhinavv245 commented 2 days ago

Item out of stock flow

/on_select_1

if item is out of stock, its @ondc/org/item_quantity should be updated to 0 in quote/breakup
remove empty objects (measure) from quote/breakup
why are duplicate delivery and convenience charges applied in quote/breakup

Note: Please provide cancellation flows (Buyer side and seller side cancellation both)

@asif0777

ONDC-Official / verification-logs