search

ONLYOFFICE / Docker-Docs

ONLYOFFICE Docs is an online office suite comprising viewers and editors for texts, spreadsheets and presentations and enabling collaborative editing in real time. The suite provides maximum compatibility with Office Open XML formats: .docx, .xlsx, .pptx.
GNU Affero General Public License v3.0
13 stars 15 forks source link

No default plugins #78

Open rizlas opened 1 year ago

rizlas commented 1 year ago

This PR aims to fix and close #69 . The aforementioned PR is currently applying modifications to all the images without using inheritance and it is also not working (sdkjs-plugins folder appears empty).

Proposed solution in this PR, removes only the content of sdkjs-plugins directory, except for js and css files in ds-service image. Final result are images without default plugins and plugin manager.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

rizlas commented 1 year ago

Hi @agolybev , is this PR going to be reviewed? With the addition of plugin manager the problem is not solved, we currently aim to not have the plugin manager showed in the UI and to not have default plugins installed.

pluginmanager command not available also inside containers.

If you consider this a valid PR, we should also consider to create a dedicated dockerfile.

Regards

rizlas commented 1 year ago

Try to tag also @VyacheslavSemin

GeorgeONLYOFFICE commented 1 year ago

Hi @rizlas We cannot merge your PR as here you offer the solution that doesn't fully delete all contents from sdkjs-plugins directory. Our initial goal was to fully delete the contents of this directory. Please see PR #97 as a possible way to achieve your goal.

rizlas commented 1 year ago

Hi @GeorgeONLYOFFICE, an answer is already a great achievement after 5 months. As already stated my goals is an image without default plugins and plugin manager, so that a simple user won't be able to install plugin.

I'm using this repo to build my custom (ee edition) onlyoffice image, with custom fonts and plugins (following your instruction in Kubernetes-Docs repository).

Notice that this feature is/was a main topic in CS3 community. Institutions that use a private sync and share system with onlyoffice, often don't want to have (e.g.) google translate as a default plugin or allow the installation of plugins that are not privacy complaint.

Last but not least, I would like to point out that your Dockerfile.noplugin file is not aligned with main Dockerfile.

Regards