Closed TobyFlynn closed 1 year ago
Good question @bozbez is this something we rely on under the hood anywhere in Hydra?
No shouldn't be, our dat declaration is based on hyd_all calls.
Then I think @TobyFlynn you should go ahead with the proposed change!
Currently when you declare a dat with a null data pointer for non-MPI backends this returns a valid dat that OP2 has allocated memory for itself. However, for MPI backends a null op_dat is returned instead. This commit changes things so that all backends return a valid dat when a null dat pointer is passed to op_decl_dat but before I open a pull request I wanted to check if we want the same behaviour for non-MPI and MPI backends in this case? I don't know if some applications rely on this behaviour for MPI apps