OP-Engineering / op-sqlite

Fastest SQLite library for react-native by @ospfranco
MIT License
603 stars 40 forks source link

Update libsql to 3d52c07f5d1df9caa56fb201fb3009924b26fd05 #188

Closed haaawk closed 4 days ago

haaawk commented 4 days ago

It includes some fixes to vector search.

haaawk commented 4 days ago

Android tests are passing:

image
haaawk commented 4 days ago

I'm struggling a bit with getting IOS simulator to run @ospfranco

╰──> yarn ios
info Found Xcode workspace "OPSQLiteExample.xcworkspace"
info Launching iPhone 15 Pro (iOS 17.5)
info Building (using "xcodebuild -workspace OPSQLiteExample.xcworkspace -configuration Debug -scheme debug -destination id=E69CF751-2C6A-4B96-B9E6-162DD7B0A11D")

info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor 

node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Error: Failed to build ios project. "xcodebuild" exited with error code '70'. To debug build logs further, consider building your app with Xcode.app, by opening 'OPSQLiteExample.xcworkspace'.".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Node.js v18.17.0
ospfranco commented 4 days ago

Just FYI the in-app tests are now baked into the Github actions tests, no need to posts screenshots. The error you posted is not pointing to the actual Xcode error, it's better if you build it from xcode and you check the native build logs there.

At least on this build logs, it seems the chosen emulator does not exist on CI:

https://github.com/OP-Engineering/op-sqlite/actions/runs/12031060231/job/33539770529?pr=188

I can see you didn't change anything though. Let me try a local build.

ospfranco commented 4 days ago

It's compiling just fine for me. Maybe your environment changed since last time.

CleanShot 2024-11-26 at 14 20 48@2x

haaawk commented 4 days ago

Updating simulator to IOS 18.1 helped:

image
ospfranco commented 4 days ago

Nice!

I fixed the CI command, you can merge main into your branch or rebase if you want, should fix the CI tests

haaawk commented 4 days ago

It seems you didn't do a pod install? I'm getting changes on the Podfile.lock:

CleanShot 2024-11-26 at 14 23 53@2x

I did - just didn't commit Podfile.lock

haaawk commented 4 days ago

Rebased on main

ospfranco commented 4 days ago

Thanks, release 11.0.1 is now building and will contain this bump.

haaawk commented 4 days ago

Thanks, release 11.0.1 is now building and will contain this bump.

Thanks @ospfranco !!!

simonwh commented 3 days ago

Thanks guys! @ospfranco - can you push 11.0.1 to npm?

ospfranco commented 3 days ago

It's already out

https://github.com/OP-Engineering/op-sqlite/releases/tag/11.0.1

simonwh commented 3 days ago

@ospfranco it's not pushed to npm https://www.npmjs.com/package/@op-engineering/op-sqlite?activeTab=versions