Closed haaawk closed 4 days ago
Android tests are passing:
I'm struggling a bit with getting IOS simulator to run @ospfranco
╰──> yarn ios
info Found Xcode workspace "OPSQLiteExample.xcworkspace"
info Launching iPhone 15 Pro (iOS 17.5)
info Building (using "xcodebuild -workspace OPSQLiteExample.xcworkspace -configuration Debug -scheme debug -destination id=E69CF751-2C6A-4B96-B9E6-162DD7B0A11D")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor
node:internal/process/promises:288
triggerUncaughtException(err, true /* fromPromise */);
^
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Error: Failed to build ios project. "xcodebuild" exited with error code '70'. To debug build logs further, consider building your app with Xcode.app, by opening 'OPSQLiteExample.xcworkspace'.".] {
code: 'ERR_UNHANDLED_REJECTION'
}
Node.js v18.17.0
Just FYI the in-app tests are now baked into the Github actions tests, no need to posts screenshots. The error you posted is not pointing to the actual Xcode error, it's better if you build it from xcode and you check the native build logs there.
At least on this build logs, it seems the chosen emulator does not exist on CI:
https://github.com/OP-Engineering/op-sqlite/actions/runs/12031060231/job/33539770529?pr=188
I can see you didn't change anything though. Let me try a local build.
It's compiling just fine for me. Maybe your environment changed since last time.
Updating simulator to IOS 18.1 helped:
Nice!
I fixed the CI command, you can merge main into your branch or rebase if you want, should fix the CI tests
It seems you didn't do a
pod install
? I'm getting changes on the Podfile.lock:
I did - just didn't commit Podfile.lock
Rebased on main
Thanks, release 11.0.1
is now building and will contain this bump.
Thanks, release
11.0.1
is now building and will contain this bump.
Thanks @ospfranco !!!
Thanks guys! @ospfranco - can you push 11.0.1 to npm?
It's already out
https://github.com/OP-Engineering/op-sqlite/releases/tag/11.0.1
@ospfranco it's not pushed to npm https://www.npmjs.com/package/@op-engineering/op-sqlite?activeTab=versions
It includes some fixes to vector search.