search

OP-TEE / build

Makefiles to use OP-TEE on various platforms
109 stars 218 forks source link

qemuv8: fix to enable Rust by default on x86_64 hosts only #776

Closed bingzhux closed 3 months ago

bingzhux commented 3 months ago

When building on x86_64 host, the rust application won't be built by default, this is because the "UNAME_M" is not yet defined/assigned.

We can move "include common.mk" line above, because in common.mk file the "UNAME_M" is assigned with correct value.

jbech-linaro commented 3 months ago

@jforissier , I might be wrong, be didn't we make it behave like this intentionally, since building Rust added a lot of build time?

jforissier commented 3 months ago

@jforissier , I might be wrong, be didn't we make it behave like this intentionally, since building Rust added a lot of build time?

No, it doesn't take that long (~ 30 seconds on my build machine). It used to be very slow when Rust support was introduced but not anymore.

jbech-linaro commented 3 months ago

No, it doesn't take that long (~ 30 seconds on my build machine). It used to be very slow when Rust support was introduced but not anymore.

Ok, glad to hear that I was wrong :)