OPEN-NEXT / wp2.2_dev

Initial proof-of-concept of open source development (OSD) status dashboard with data-mining & visualisation components
https://opennext.eu/
GNU Affero General Public License v3.0
3 stars 1 forks source link

Understand file change actions codes #32

Closed jbon closed 2 years ago

jbon commented 4 years ago

For some reason, while most of dict elements in the list of dict "files" in a commit contain the keys "action", "added" and "removed", some of them don't.

The meaning of the keys "added" and "deleted" is pretty clear, but I don't understand why they would be missing for some commits.

The meaning of the key "action" is clear in most cases, when the value is "A", "D" or "M" (I guess added, deleted, modified). But there are other codes who's meaning is not clear to me. We see occasionally the codes R052, R074, R066, C085, DD, MM.

There are also some other attributes we haven't been using so far ("indexes", "modes") and whose meaning is not clear to me.

We should investigate the meaning of all these codes and attributes and why they are sometimes present and sometimes not.


Some examples:

in commit 10ed9335c327415e31b8432b752d5c5d1bb0a4d1 in (a fork of) jbon/github-mining:

        "files": [
            {
                "added": "9",
                "file": "README.md",
                "removed": "4"
            },

The key "action" is missing.

in commit 83872323d9d5b65b723871b6da76e78ff3c73de0 in jurgenwesterhoff/bGeigieNanoKit:

            {
                "action": "R066",
                "file": "hardware/bGeigieNanoKit.brd",
                "indexes": [
                    "634a725",
                    "b787bbd"
                ],
                "modes": [
                    "100755",
                    "100755"
                ],
                "newfile": "hardware/bGeigieNanoKit/bGeigieNanoKit.brd"
            },

The keys "added" and "deleted" are missing.

jbon commented 4 years ago

Below a most extensive list of examples based on the processing of:

Warning: missing file edition information (key 'action') for file README.md in commit 10ed9335c327415e31b8432b752d5c5d1bb0a4d1
Warning: missing file edition information (key 'action') for file analysisActivityDistribution.py in commit 10ed9335c327415e31b8432b752d5c5d1bb0a4d1
Warning: missing file edition information (key 'action') for file gomine.py in commit 10ed9335c327415e31b8432b752d5c5d1bb0a4d1
Warning: missing file edition information (key 'action') for file graphs/graphs.7z in commit 10ed9335c327415e31b8432b752d5c5d1bb0a4d1
Warning: missing file edition information (key 'action') for file gomine.py in commit eaffb1c3fa5816b97ebe40af5ebda9517406e054
Warning: missing file edition information (key 'action') for file README.md in commit 66df1fe176458d6d5b085d2aad4b6e90ad3c286a
Warning: missing file edition information (key 'action') for file gomine.py in commit 66df1fe176458d6d5b085d2aad4b6e90ad3c286a
Warning: missing file edition information (key 'action') for file goCreateGraphs.py in commit 92636cffbfdf11172879d051fb69407073d291ef
Warning: missing file edition information (key 'action') for file goCreateGraphs.py in commit ba76c72bee542647b78b0dd30721bf5819c387ec
Warning: missing file edition information (key 'action') for file gomine.py in commit fe8e29f80b69f35a19dd0d7e7011f892d7f284df
Warning: missing file edition information (key 'action') for file hardware//bGeigieNanoKit.brd in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'action') for file hardware//bGeigieNanoKit.sch in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'action') for file hardware//open_hw_sockets.lbr in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'added') for file hardware/bGeigieNanoKit.brd in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'removed') for file hardware/bGeigieNanoKit.brd in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'added') for file hardware/bGeigieNanoKit.sch in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'removed') for file hardware/bGeigieNanoKit.sch in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'added') for file hardware/open_hw_sockets.lbr in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'removed') for file hardware/open_hw_sockets.lbr in commit 83872323d9d5b65b723871b6da76e78ff3c73de0
Warning: missing file edition information (key 'action') for file README.md in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_GFX/Adafruit_GFX.cpp in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_GFX/Adafruit_GFX.h in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_GFX/README.txt in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_GFX/glcdfont.c in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_GFX/license.txt in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_SSD1306/Adafruit_SSD1306.cpp in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_SSD1306/Adafruit_SSD1306.h in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_SSD1306/README.txt in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_SSD1306/examples/ssd1306_128x32_i2c/ssd1306_128x32_i2c.ino in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_SSD1306/examples/ssd1306_128x32_spi/ssd1306_128x32_spi.ino in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_SSD1306/examples/ssd1306_128x64_i2c/ssd1306_128x64_i2c.ino in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_SSD1306/examples/ssd1306_128x64_spi/ssd1306_128x64_spi.ino in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
Warning: missing file edition information (key 'action') for file libraries/Adafruit_SSD1306/license.txt in commit f43da848f99d88f288ac5ff05b4e4ba6ec426ae4
jbon commented 4 years ago

By the way, sometimes commit don't even have the attribute "file", and that's weird. I don't have an example right now. I'll post one as soon as I find it.

penyuan commented 4 years ago

Thanks.

I'm just adding this comment to specifically mention that this issue is based on issues #13 and #29 which are closed and will be continued here.