search

OPENDAP / bes

The BES framework, which forms the basis for the Hyrax server
GNU Lesser General Public License v3.0
13 stars 19 forks source link

Hyrax 1524 #980

Closed kyang2014 closed 1 month ago

kyang2014 commented 1 month ago

Implement the merge_dmrpp testsuite and also fix the issue documented in HYRAX-1537.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kyang2014 commented 1 month ago

Looks good. And if the missing variable is being added in the grid_1_2d.h5 without issue then it looks ready to merge.

The merged dmrpp file is compared with the baseline file grid_1_2d.h5.dmrpp.mrg.baseline. If it fails, the test will not get passed. The baseline file has the offset and length of the missing variables.