search

OPM / opm-simulators

OPM Flow and experimental simulators, including components such as well models etc.
http://www.opm-project.org
GNU General Public License v3.0
124 stars 122 forks source link

Only update target of group-controlled wells during updateAndCommunicate #5748

Closed steink closed 5 days ago

steink commented 1 week ago

The updateWellStateWithTarget for all wells can be problematic here. In particular, this is the case for thp-wells, since in this case updateWellStateWithTarget only provides an initial guess well-state. This means that at this stage, we may have converged thp-wells that after going through updateWellStateWithTarget are no longer convereged, which again may prevent overall convergence.

I can't see that updateAndCommunicateGroupData changes any well control-modes, so there should be no reason to update the target of wells not under group control here?

This PR just skips the updateWellStateWithTarget for wells not under group control

steink commented 1 week ago

jenkins build this failure_report please

totto82 commented 1 week ago

I looked at many of the test failures and I didn't notice anything that should hinder an update of data. If all of them are reasonable, we should merge this.

totto82 commented 6 days ago

jenkins build this failure_report please

totto82 commented 5 days ago

This should be merged. It need a update of the reference results, due to mostly minor numerical noise. I will start the update process

totto82 commented 5 days ago

jenkins build this update_data please

totto82 commented 5 days ago

jenkins build this opm-tests=1255 please