search

ORCID / python-orcid

Python wrapper around ORCID API
BSD 3-Clause "New" or "Revised" License
91 stars 26 forks source link

documentation: fixes documentation examples #11

Closed Panos512 closed 6 years ago

Panos512 commented 8 years ago

Signed-off-by: Panos Paparrigopoulos panos.paparrigopoulos@cern.ch

kaplun commented 8 years ago

@Panos512 is this now compatible with RC1 or RC2?

Panos512 commented 8 years ago

That's RC1, which is the old schema, so I am gonna close it.

Although the minimal-example from the documentation:

{
    'title': {'title': 'API Test Title'},
    'type': 'JOURNAL_ARTICLE',
    'external-ids': [{
        'external-id': [{
            'external-id-type': 'source-work-id',
            'external-id-value': '1234'
        }]
    }]
}

Which is RC2 is currently failing with the following message:

'Can not deserialize instance of org.orcid.jaxb.model.record_rc2.ExternalIDs out of START_ARRAY token\n at [Source: org.apache.catalina.connector.CoyoteInputStream@10e721f8; line: 1, column: 2] (through reference chain: org.orcid.jaxb.model.record_rc2.Work["external-ids"])
kaplun commented 8 years ago

@Panos512 can you open a dedicated Issue with that bug? If the documentation is still in need to be improved maybe you can force-push with the changes to make it RC2 compatible. (and we keep it open until the issue you are having is solved)