search

ORCID / python-orcid

Python wrapper around ORCID API
BSD 3-Clause "New" or "Revised" License
91 stars 26 forks source link

Allow setting requests timeout #24

Closed michamos closed 6 years ago

michamos commented 6 years ago

It is recommended by the requests documentation to always set timeouts in production code:

You can tell Requests to stop waiting for a response after a given number of seconds with the timeout parameter. Nearly all production code should use this parameter in nearly all requests.

This PR allows setting a timeout when instanciating the API, which is then used for all requests.

MSusik commented 6 years ago

I will take care of this PR this week.

Thanks a lot for contributing!

michamos commented 6 years ago

@MSusik I addressed your formatting issues.

MSusik commented 6 years ago

@michamos You can install the library with the change from PyPI: 1.0.2 release

michamos commented 6 years ago

:+1: Thanks for the quick release!