search

ORCID / python-orcid

Python wrapper around ORCID API
BSD 3-Clause "New" or "Revised" License
91 stars 26 forks source link

Allowed non-ASCII characters in names for get_login_url. #9

Closed bronger closed 8 years ago

bronger commented 8 years ago

Non-ASCII characters in family_names and given_names lead to UnicodeEncodeErrors. I observed this with Python 2.6. It does not occur with Python 3 but doesn't do any harm either.

kaplun commented 8 years ago

Hi! Would it be possible for you to add a test in the testsuite to prove that it indeed works?

bronger commented 8 years ago

I hope that the amended test runs through. I cannot check that.

MSusik commented 8 years ago

The Travis builds fail now: https://travis-ci.org/ORCID/python-orcid/jobs/137450150

I'll fix that

kaplun commented 8 years ago

Uh? BUT the PR was green on Travis. What happened?

MSusik commented 8 years ago

@kaplun Due to the security reasons, the PR builds are blocked. Thus, every PR has a green light. No worries though, there was only a typo.

kaplun commented 8 years ago

@MSusik What type of security reasons? Is it because the tests are running against the sandbox and hence a malicious PR could bombard ORCID's sandbox using our credentials?

EDIT (MSusik): answered personally.