search

ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Update arborx #563

Closed Rombur closed 4 years ago

Rombur commented 4 years ago

Update to use the current master of arborx and add a couple fixes that are necessary to build DTK

Rombur commented 4 years ago

Both are valid comment and they are actually fixed in my branch that uses the callback mechanic. This PR just update ArborX, I would prefer that we wait for the callback PR to fix these comments.

Rombur commented 4 years ago

retest this please

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@edfa050). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #563   +/-   ##
=========================================
  Coverage          ?   95.88%           
=========================================
  Files             ?       86           
  Lines             ?     6009           
  Branches          ?        0           
=========================================
  Hits              ?     5762           
  Misses            ?      247           
  Partials          ?        0
Impacted Files Coverage Δ
...ckages/Discretization/src/DTK_PointSearch_decl.hpp 100% <ø> (ø)
...oudProblemGenerator/ExodusProblemGenerator_def.hpp 100% <100%> (ø)
...ackages/Discretization/src/DTK_PointSearch_def.hpp 99.23% <100%> (ø)
...ree/src/DTK_DetailsNearestNeighborOperatorImpl.hpp 100% <100%> (ø)
.../src/DTK_DetailsMovingLeastSquaresOperatorImpl.hpp 100% <100%> (ø)
...s/Meshfree/test/tstDetailsCommunicationHelpers.cpp 98.01% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edfa050...99f0a0e. Read the comment docs.

Rombur commented 4 years ago

I think this is ready to be merged. The fixes Damien wants will be done in a later PR where we use the new callback mechanism.