ORNL / ReSolve

Library of GPU-resident linear solvers
Other
51 stars 1 forks source link

Enhancements to Matrix Functions #135

Closed pelesh closed 4 months ago

pelesh commented 5 months ago

Several enhancements to matrix operations including:

pelesh commented 4 months ago

Code builds cleanly on x86_64 and AMD GPUs. All tests pass (run manually, CI pipelines are broken).

kswirydo commented 4 months ago

When I am trying to compile, I am getting linker error [ 78%] Linking CXX executable version.exe In file included from /people/swir617/ReSolve/tests/unit/matrix/runMatrixIoTests.cpp:7: /people/swir617/ReSolve/tests/unit/matrix/MatrixIoTests.hpp: In member function ‘ReSolve::tests::TestOutcome ReSolve::tests::MatrixIoTests::cooMatrixExport()’: /people/swir617/ReSolve/tests/unit/matrix/MatrixIoTests.hpp:89:37: error: ‘max_element’ is not a member of ‘std’ 89 | const index_type N = 1 + *(std::max_element(rows.begin(), rows.end()));

Can be fixed with #include <algorithm>

kswirydo commented 4 months ago

LArge example works correctly.

maksud commented 4 months ago

All tests passes successfully. Looks good to me.