search

ORNL / ReSolve

Library of GPU-resident linear solvers
Other
58 stars 2 forks source link

Update spack_cpu_build.yaml to not checkout in base image build step #186

Closed cameronrutherford closed 2 months ago

cameronrutherford commented 2 months ago

In debugging https://github.com/LLNL/hiop/pull/695, I realised that the clone happens at multiple steps in the pipelines, and doesn't need to.

By not cloning when building the base image, we speed up the initial builds a little. We could also kick off the base image pipeline in a separate workflow, and it would surely complete in time for a full spack build (the spack job only needs it to upload to the remote registry.

There's a potential race condition with that if the spack pipeline fails quickly... so I don't see a need to do that.

cameronrutherford commented 2 months ago

We already clone the repo in the matrix of jobs in line 83 of the updated file, and so this clone step I remove is unecessary.

pelesh commented 2 months ago

CC @stonecoldhughes