search

ORNL / intersect-architecture

https://intersect-architecture.readthedocs.io
Creative Commons Attribution 4.0 International
2 stars 0 forks source link

add contributors to team commits #38

Open naughtont3 opened 1 month ago

naughtont3 commented 1 month ago

This change is mainly intended to bring the rest of the team into the Git history. We exported the old repo and started with a clean git history when moving to GitHub. These attributions should have been on the initial commit.

naughtont3 commented 1 month ago

Please confirm the following:

  1. Your email is correct to map to GitHub username *. Confirm ok with including your email in public git history (if rather, can put xxx@no-reply)
  2. Name appears correctly (no misspellings, etc.)
naughtont3 commented 1 month ago

Thanks, I'll fix that typo on full Team listing. BTW, this ticket was just to bring over the items from git history contribs. Full Team contributions are reflected on the www page you mentioned Mike.

naughtont3 commented 1 month ago

Olga Kuchar should be on the list.

@pwidene Initial thinking was just to take git log output and for this pr, and use www page for full Team listing. In part b/c i did not know if everyone had github id's. On further reflection, thinking we just use name/email address and if align w/ github id then "good enough" if not align or no-github-id, then still no harm. Sound good?

pwidene commented 1 month ago

@naughtont3 Olga is probably not on any git commit for the ORNL gitlab repo. However she did create content which was in the original Word version of the SOS spec that predated our use of gitlab, and which has persisted through to what we're showing publicly. I'm fine whatever attribution scheme y'all are coming up with, just wanted to note this.

naughtont3 commented 1 month ago

@pwidene Yes, totally agree. I have added Olga to this msg. Will not have effect of adding to github contributors list, but i think that its better. Thanks and good suggestion.

naughtont3 commented 1 month ago

Thanks for all response. I've decided to go the route of including @ornl.gov addresses and extending the list to all from the Team www view. All emails that are included here are also visible on webpages at ornl, so do not feel there's a problem with adding them. I'll let this sit to next week in case there are any objections and then click the clicks.

naughtont3 commented 1 month ago

For past reviews: added olga (@pwidene) fixed typos in 9ed643c2878d46ae2dcffb616c2a8ba0174d2b65 (@MichaelBrim).