OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer
https://osc.github.io/Open-OnDemand/
MIT License
4 stars 1 forks source link

Crashes if not a git repo #169

Closed nickjer closed 6 years ago

nickjer commented 6 years ago

The app crashes if it isn't a git repo (i.e., doesn't have the .git/ directory). This may need to be resolved if going forward with RPM packaging.

brianmcmichael commented 6 years ago

This is caused by the use of gitsync https://github.com/OSC/ood-fileexplorer/blob/master/app.js#L12

This could be resolved with error handling, or with embedding the version number elsewhere in the app, although in the case of the latter we'll need to remember to keep it updated.