search

OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer
https://osc.github.io/Open-OnDemand/
MIT License
4 stars 1 forks source link

Tree root #174

Closed brianmcmichael closed 5 years ago

brianmcmichael commented 6 years ago

Resolves #166 Also fixes #173 in conjunction with cloudcmd update

This PR is in a testable state.

This branch is currently set to access the roottree branch of cloudcmd. Once the changes are approved, the cloudcmd app will need a version update and this PR will need an update to reference that version and the npm-shrinkwrap will need modification.

For now, evaluation can be performed by switching to the treeroot branch of file explorer and performing an npm i command.

ericfranz commented 6 years ago

I click on the tree root folder to go to that folder and get an error instead:

screen 2018-02-02 at 2 19 38 pm

ericfranz commented 6 years ago

Also specify ?treeroot=/fs/scratch/PZS0562 and root title is /fs/scratch/PZS0562 but ?treeroot=/fs/scratch/PZS0562/ then root title is /fs/scratch/PZS0562/. Probably should consistently display /fs/scratch/PZS0562 without the trailing slash in both cases.

ericfranz commented 6 years ago

Didn't look at the code - Jeremy will do that. But functionally this is really cool!

ericfranz commented 5 years ago

We will be migrating away from cloud commander in a future version, so marking this as "wontfix".