OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer
https://osc.github.io/Open-OnDemand/
MIT License
4 stars 1 forks source link

Fix jquery version #203

Closed ericfranz closed 5 years ago

ericfranz commented 5 years ago

This PR ensures cloud commander client code uses 1 jQuery version, jquery-3.4.1.min.js with the migrate file for backwards compatibility (instead of two separate ones).

Reviewer notes:

If you are curious about this:

-        var jQuery12 = $.noConflict(true);
+        var jQuery12 = jQuery;

this was when there were two different jQuery versions. The safest fix was the one with the fewest changes. I didn't do the find replace jQuery12 with jQuery in order to remove this which I could have, that is probably safe but would have touched more files. Anyways, this code is going away soon in (OnDemand 2).

Also I removed the unused console-io module because that has a dependency on an old jquery as well even though we don't use it.