OSGeo / osgeo

The Open Source Geospatial Foundation is not-for-profit organization to empower everyone with open source geospatial. Directly supports projects as an outreach and advocacy organization providing financial, organizational and legal support. Works with our sponsors and partners for open software, standards, data, research and education.
http://www.osgeo.org
363 stars 68 forks source link

Use of embedded web maps #128

Closed jodygarnett closed 6 years ago

jodygarnett commented 6 years ago

Including maps that are fast and look amazing is important in showcasing our expertise as cartographers and credibility as technologists.

Gretchen has done a great job on the cartography, as we can see in the style guide, this issue is used to double check how well these maps are integrated into our website.

Here are pages that are intended to include both an embedded web map at the top of the page, and a full screen map used to explore.

How to use:

  1. geo-for-all displays map as part of the initial page

  2. list maps (local-chapters, members): use filter dropdown and toggle map

My understanding is the maps were removed from list pages due to design change (to hide filters unless used) and tile performance.

The following I thought would use maps, as they have a location, but it is not supported by the wireframes (as such they can be viewed as an enhancement):

jodygarnett commented 6 years ago

I am unsure if the non-functioning maps I see are due to browser differences:

Safari

Safari 11.0 http://osgeo.getinteractive.nl/geo-for-all-labs/ Filter --> Toggle Map

labsmap-safari

Chrome

Chrome 61.0 11.0 http://osgeo.getinteractive.nl/geo-for-all-labs/ Filter --> Toggle Map

labsmap-chrome

Firefox

Firefox 56.0 http://osgeo.getinteractive.nl/geo-for-all-labs/ Filter --> unable to display filter dropdown!

Firefox 56.0 http://osgeo.getinteractive.nl/initiatives/geo-for-all/

labsmap-firefox

vloemans-marc commented 6 years ago

Using an iPhone 6 Plus, I don't see any maps on screen. Have filed a bug (first ever in my life...what's next....me coding ;-)

jodygarnett commented 6 years ago

And to think many individuals start their open source journey by filing an issue; you are just taking a different approach @vloemans-marc .

gisnederland commented 6 years ago

on Win10 - 64 bitOS: http://osgeo.getinteractive.nl/geo-for-all-labs/ chrome (61.0.3163.100): tiles display OK / point markers display OK but no interaction IE (11.674): Header (text) and footer (sponsors) of page loads, middle part with labs does not load at all Edge: tiles display OK / point markers display OK but no interaction FireFox (56.0.1): button filter does not respond

gisnederland commented 6 years ago

On Android 6.0.1 http://osgeo.getinteractive.nl/geo-for-all-labs/ chrome (61.0.3163.98): tiles display OK / point markers display OK but no interaction

gisnederland commented 6 years ago

On Android (tablet) http://osgeo.getinteractive.nl/geo-for-all-labs/ chrome (55.0.2883.91): tiles display OK / point markers display OK but no interaction standard android browser (4.3.1-1754): page won't load (middle part with labs doesn't load).

ghost commented 6 years ago

Firefox 56.0 http://osgeo.getinteractive.nl/geo-for-all-labs/ Filter --> unable to display filter dropdown! Firefox 56.0 http://osgeo.getinteractive.nl/initiatives/geo-for-all/ embedded map not displayed

Filter dropdown is now working and map is displayed in Firefox.

gisnederland commented 6 years ago

Regarding IE: debugging shows erros "promise is not defined"

Possible solution: https://stackoverflow.com/questions/36831372/promise-is-undefined-in-ie

gisnederland commented 6 years ago

standard Android (4.3.1) browser on Samsung tablet still not working as well. Perhaps the same "promise"-problem?

ghost commented 6 years ago

Regarding IE: debugging shows erros "promise is not defined"

The promise error is fixed by using the polyfill.

Also the interaction that was missing is added to the maps.

standard Android (4.3.1) browser on Samsung tablet still not working as well. Perhaps the same "promise"-problem?

@gisnederland Could you test the new version of the map on that specific Android version? I tested on other versions and it works, but I don't have that specific version available.

gisnederland commented 6 years ago

Works like a charm on the Android 4.3.1 browser.