OSIPI / osipi.github.io

main OSIPI website
https://osipi.ismrm.org
MIT License
7 stars 29 forks source link

Shape of the headshot is different across pages #48

Closed fedorov closed 8 months ago

fedorov commented 4 years ago

It's not a huge deal, but I find it rather idiosyncratic and not very professional to have differences in styling of the headshot - sometimes those are round, sometimes ellipsoid with different aspect ratios. Is this intentional, or just because fixing it is not straightforward?

notZaki commented 4 years ago

The shape is based on the source photo's aspect ratio, i.e. a square photo will become a circle while a rectangular one becomes an ellipsoid. One way to fix the shapes would be to use a consistent aspect ratio for all the images in assets/img/headshots/, e.g. crop them to 1:1 aspect ratio

fedorov commented 4 years ago

Thanks Zaki, makes sense. IMHO, this would be good to fix, if everyone agrees, but not a high priority of course.

plaresmedima commented 4 years ago

It's been irritating me a little as well but have not had a chance to fix it ;-)


Steven Sourbron Chair in Medical Imaging Physics Department of Infection, Immunity and Cardiovascular Disease University of Sheffield

On Mon, 10 Feb 2020 at 18:47, Andrey Fedorov notifications@github.com wrote:

Thanks Zaki, makes sense. IMHO, this would be good to fix, if everyone agrees, but not a high priority of course.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OSIPI/osipi.github.io/issues/48?email_source=notifications&email_token=ABOFKA7HWITDC7PLYP6UKHDRCGOMLA5CNFSM4KSSXQ62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELJZARY#issuecomment-584290375, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOFKA7RG5ZNVDRKA7Y5SG3RCGOMLANCNFSM4KSSXQ6Q .

Aditish51 commented 8 months ago

Hello, This is Aditi .Can I give this issue a try? I just need to fix the aspect ratio for the images located in assets/img/headshots/.

petravanhoudt commented 8 months ago

Hi @Aditish51 thank you for your offered help, however, we are not maintaining this website anymore as we are transitioning to a different domain.