OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
99 stars 76 forks source link

`apply_mask` dimension check should be agnostic of order of dimensions #1402

Open leewujung opened 1 month ago

leewujung commented 1 month ago

Currently the dimension check in apply_mask would check for matching dimension length and order for ping_time and depth (or range_sample). I've encountered the situation where the Sv or MVBS data being masked and the mask have the same length of the dimension but not the order. I think we can relax the order requirement since that is something that easily get altered depending on prior operations on these datasets.