`Regions2D.close_region` to also modify the internal dataframe?

OSOceanAcoustics / echoregions

Interfacing water column sonar data with annotations and labels

https://echoregions.readthedocs.io/

Apache License 2.0

6 stars 6 forks source link

`Regions2D.close_region` to also modify the internal dataframe? #210

Open leewujung opened 1 month ago

leewujung commented 1 month ago

I noticed that Regions2D.close_region right now returns a dataframe that has the regions closed, but the internal dataframe of the Regions2D object is unchanged.

I feel it would be more intuitive if the internal dataframe is modified, instead of returning a copy with the modified dataframe.

Thoughts? @ctuguinay

ctuguinay commented 1 month ago

@leewujung Ah yeah I think you're right. I'll add this