Updated logger now spits pointers into the log...

OSVR / OSVR-Core

The core libraries, applications, and plugins of the OSVR software platform.

Apache License 2.0

329 stars 124 forks source link

Updated logger now spits pointers into the log... #475

Closed rpavlik closed 7 years ago

rpavlik commented 8 years ago

The most noticeable place is in the canonical "third line of the log", where it would print the location of the app it's logging for.

On a 32-bit build:

Sept 20 14:08:19.591 info [OSVR]: 0F1FCF74C:\Users\Ryan\install\OSVR-Core-alt2-vc14\bin\osvr_server.exe

Pretty sure this printed a message (string literal?) or something where the pointer is before the spdlog update. There are other points where I see pointers showing up in my log - presumably must be the same call pattern.

cc @godbyk

godbyk commented 8 years ago

I've already fixed this in the logger-updates branch: https://github.com/OSVR/OSVR-Core/commit/cc2a697a3642943be23f31b06791df9fa21edf42.

rpavlik commented 8 years ago

Ah, great. Is that ready for pull request, testing, etc?

godbyk commented 8 years ago

It's ready for testing.

I was trying to test it locally, but osvr_server is crashing on me in a seemingly unrelated place. (It tries to deref a null pointer while copying the (empty) context name from the multiserver plugin. No idea why/how yet.)

rpavlik commented 7 years ago

Fixed with #484