OSeMOSYS / otoole

OSeMOSYS Tools for Energy
https://otoole.readthedocs.io
MIT License
25 stars 19 forks source link

[Bug]: Incorrect Total Discounted Cost Calculation #237

Closed trevorb1 closed 1 week ago

trevorb1 commented 1 month ago

The Issue

I believe the otoole total discounted cost calculation is not currently taking into account storage costs.

https://github.com/OSeMOSYS/otoole/blob/cfa2910c17c85f22f5a081e22a768514901161be/src/otoole/results/result_package.py#L581-L663

This issue originated from a bug in the OSeMOSYS objective equation, as described here, with fixes here and here. However, the otoole calc has not been updated to reflect these updates.

Expected Behavior

No response

Steps To Reproduce

No response

Log output

No response

Operating System

Linux

What version of otoole are you running?

1.1.3

Possible Solution

No response

Anything else?

No response

trevorb1 commented 1 week ago

closes with #240