search

OV2 / RapidCRC-Unicode

Windows tool to quickly create and verify hash checksums
https://www.ov2.eu/programs/rapidcrc-unicode
GNU General Public License v2.0
300 stars 29 forks source link

HBITMAPs in CShellExt::QueryContextMenu are getting leaked #67

Closed chrdavis closed 5 years ago

chrdavis commented 5 years ago

The bitmaps you pass to the menu items are getting leaked every time the menu is invoked in explorer. Please move these HBITMAPs to class members of CShellExt, create them once in the constructor or on demand, and then call DeleteObject on them in the destructor.

OV2 commented 5 years ago

Thank you for the hint. As far as I can see this was only an issue when running on win2k/xp, on later systems this is handled by the IconBitmapUtils class. Should still be changed of course.