search

OWASP / ZSC

OWASP ZSC - Shellcode/Obfuscate Code Generator https://www.secologist.com/
https://www.secologist.com/
Other
648 stars 217 forks source link

pep8 fixes #72

Closed CodeMaxx closed 8 years ago

CodeMaxx commented 8 years ago

Code formatting is absolutely necessary for large project like ours to keep common formatting standards for all developers and also improve readability of the code. Thus I formatted the code according to pep8 rules using google's yapf python formatter using the default settings.

Any discussions regarding using a different formatter or having some personal settings for yapf are welcome.

@Ali-Razmjoo @Pratik151 @jowasp

Pratik151 commented 8 years ago

I think this will change most of the code so its good if its done by Ali. What do you say?

Ali-Razmjoo commented 8 years ago

It takes much time to review the codes, but i'll try.

CodeMaxx commented 8 years ago

@Pratik151 This software does not change the code, it just reformats it....you know like keeping proper amount of indentation etc. So I mean the logic and syntax will remain the same.

@Ali-Razmjoo I've been using this software since 6 months for all my python project and have never had any errors on reformatting. Also yapf has a --verify flag to check for syntax error after reformatting. I used this flag but it gave no errors. We did this in symengine(Another open source project I used to work on) as well.So I think all should be fine. If you still want to be very sure then you'll have to review all the code.

CodeMaxx commented 8 years ago

@Ali-Razmjoo Merge conflicts fixed

CodeMaxx commented 8 years ago

@Ali-Razmjoo Can you block other PRs until this is merged? Otherwise merge conflicts would have to be corrected again and again. I hope you understand.

Ali-Razmjoo commented 8 years ago

thanks, merged