search

OWASP / joomscan

OWASP Joomla Vulnerability Scanner Project https://www.secologist.com/
https://www.secologist.com/open-source-projects
GNU General Public License v3.0
1.08k stars 244 forks source link

PR modularize code #24

Closed StPanning closed 6 years ago

StPanning commented 6 years ago

moves code in modules and functions makes variables private (my... ) where possible uses 'use ...' directive instead of 'do...'

pes-soft commented 6 years ago

Hi StPanning, When I tried your PR on Kali Linux, I've received an error running joomscan.pl:

Can't locate JoomScan/Check.pm in @INC (you may need to install the JoomScan::Check module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.1 /usr/local/share/perl/5.26.1 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at ./joomscan.pl line 36.

It seems that your changes require the current directory . to be in INC path, which is not default on Kali.

StPanning commented 6 years ago

for now you have to be in the sam directory as joomscan.pl

this is the reason for issue #25 because this will fix this. I will implement it, as soon as my changes are approved so far.

rezasp commented 6 years ago

Hello, because of the changes in version 0.0.5, it has so many missed features, can you update it to the same version? your version is 0.0.1.

regards.