OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)
9 stars 26 forks source link

BugFix: Proper arrangement of Nos. in tables #68

Closed aayush420 closed 4 years ago

aayush420 commented 4 years ago

Fixes the single character wide Nos column to a bit more spacious column.

hblankenship commented 4 years ago

This is for a particular use case and may not be appropriate for all cases. In addition, the recommendation is to NOT use tables but come up with a different way to present the information. Finally, if you insist on using tables, you may create the necessary style within your index.md page or css folder.

aayush420 commented 4 years ago

This is for a particular use case and may not be appropriate for all cases. In addition, the recommendation is to NOT use tables but come up with a different way to present the information. Finally, if you insist on using tables, you may create the necessary style within your index.md page or css folder.

Yeah right. But having a minimum width rule is never a bad thing right? (At least that's what I thought. Please Correct me if I'm wrong...)

hblankenship commented 4 years ago

I think it would depend on the circumstance. If the first column only had 'a' or '1' it may not need 35px. Further, if the next person wants to have 12345 in the first column, 35px would not suffice.

aayush420 commented 4 years ago

I think it would depend on the circumstance. If the first column only had 'a' or '1' it may not need 35px. Further, if the next person wants to have 12345 in the first column, 35px would not suffice.

Agreed. And 35px was particularly chosen because of the fact that,... if the content is of

The main motive was to cover the majority of the cases i.e., <1000. And this is covered pretty well by 35.