search

OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)
9 stars 26 forks source link

feat(anchor): add anchors to headings #83

Closed fzipi closed 3 years ago

fzipi commented 3 years ago

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

Sometimes I find myself linking very big pages when I just need some part of the text. This adds anchors to link, a well known limitation in github pages.

hblankenship commented 3 years ago

Interesting. Could you explain a particular use-case? Github pages does, with jekyll, add ids to headers which can be used to link directly to the header, if I understand what you are requesting. For instance, you can link directly to https://owasp.org/events/#partner-events which goes to the header Partner Events on the page.

So it seems that this commit is not necessary?

That said, there are a great many places where straight html is being used instead of markdown+jekyll. In those cases, this commit would not help.

fzipi commented 3 years ago

🤔 Agreed.

Thanks for taking a look.