search

OasisDEX / oasis

Oasis - Decentralized Token Market
http://oasisdex.com/
Apache License 2.0
170 stars 56 forks source link

ci improvements #6

Open c055 opened 8 years ago

c055 commented 8 years ago

Basic travis coverage implemented in #31. Various improvements that could be made:

  1. [ ] migrate dapple docker image to canonical location (currently rainbeam/dapple)
  2. [x] reduce size of docker image
  3. [x] add npm test to test script

Image location is currently at rainbeam/dapple, which is built from https://github.com/rainbeam/dapple-travis

Would be nice to push this to a more central location e.g. nexusdev/dapple-minimal. Especially useful if this is used in a general dapple ci solution.

Image size is currently around 1GB. This can be reduced quite a lot for faster test setup. An ubuntu image with dapple and solc can be taken down to ~400MB, depending on violently you gut the OS and squash the fs layers. A minimal install based on Alpine can be brought down to 100MB (without solc).

npm test I'm not too familiar with the frontend, but maybe it has linters (semistandard?) that want checking. These could easily be added.

(ported from https://github.com/MakerDAO/maker-otc/issues/34 // posted by @rainbeam)

c055 commented 8 years ago

@jorisbontje

I have added npm test which runs the standard linter. @rainbeam can you trigger that besides the docker build?

c055 commented 8 years ago

@rainbeam:

yep, will do

c055 commented 8 years ago

@jorisbontje

npm test integrated via #51