search

ObaidUrRehman / ng-drag-drop

Drag & Drop for Angular - based on HTML5 with no external dependencies. :tada:
MIT License
239 stars 123 forks source link

Sortable: Multi list sorting bug #77

Open ObaidUrRehman opened 7 years ago

ObaidUrRehman commented 7 years ago

Item does not get removed from the list when sorted between multiple lists. See below:

multilist-sorable-bug

cah-alexsukhodolsky commented 7 years ago

@ObaidUrRehman I'm unable to reproduce this in chrome, firefox or safari (all latest versions) on my mac. Can you please specify which browser and OS you're experiencing this on?

ObaidUrRehman commented 7 years ago

I am using Chrome Version 60.0.3112.90 on Window. I'll see if I can come up with steps to reproduce this.

cah-alexsukhodolsky commented 7 years ago

I started looking into this and I'm able to reproduce it in Windows. This issue is most likely caused by a race condition. What would you think about queueing up any dom changes and performing them one at a time?

ObaidUrRehman commented 7 years ago

If this is a race condition, then it comes up too often. I am trying to come up with steps to reproduce. Can you elaborate a bit on how we can queue up DOM changes?

cah-alexsukhodolsky commented 7 years ago

sorry...been off the radar the last few days. I'll look into the problem and solution this week.

cah-alexsukhodolsky commented 7 years ago

@ObaidUrRehman Were you able to reproduce this bug? Did you find my changes fixed the issue?

ObaidUrRehman commented 7 years ago

@cah-alexsukhodolsky I am pretty slammed nowadays. Give me a few days and I will get back to you on this.

cah-alexsukhodolsky commented 7 years ago

@ObaidUrRehman any update on this?

ObaidUrRehman commented 7 years ago

@cah-alexsukhodolsky sorry for the delay on this.

I've tested this and unfortunately, it still occurs. I don't have the steps to reproduce this but dragging items back and forth repeatedly causes this issue.

vinayakpatil commented 6 years ago

please refer to: https://github.com/vinayakpatil/ng-drag-drop/tree/feat/sortable