ObjectProfile / Roassal3

The Roassal Visualization Engine
MIT License
97 stars 52 forks source link

Border color #572

Closed DurieuxPol closed 1 year ago

DurieuxPol commented 1 year ago

RSLine base color, and this may also be the case for some other shapes, is the color of their border (RSBorder) instead of their own, which is a bit odd. I don't know if it is intentional or not, and if it is the best way. For example (with the example02 of Boxplot): image I only changed the color in the initialize of RSBorder.

akevalion commented 1 year ago

In these case to change the line color there are 3 strategies

Let me know if this issue is still valid

akevalion commented 1 year ago

To draw shapes in roassal, we need an stroke paint(usually a border with solid color) and a fill paint(usually another color) over a path in cairo.

Then in roassal there are some Lines that can use the stroke and the fill paint. But stroke is complex object, it may have width size, dasyArray, cap and join styles, thats why RSBorder solve this problem.

RSLine has a both the fill paint in instance variable paint and the stroke paint in border. But the cairo path the line builds only uses the stroke paint.