ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client
https://docs.obol.tech/
Other
202 stars 90 forks source link

cmd: hardening threshold parameter checks #3242

Closed aadomn closed 2 months ago

aadomn commented 3 months ago

Ensure the threshold parameter given as input to the create dkg and create cluster commands is sound.

category: bug ticket: #3241

gsora commented 3 months ago

@aadomn could you please add unit tests for those two edge cases?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.71%. Comparing base (92ce181) to head (14b3d8a). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3242 +/- ## ========================================== + Coverage 57.67% 57.71% +0.04% ========================================== Files 211 211 Lines 30372 30389 +17 ========================================== + Hits 17517 17540 +23 + Misses 10971 10965 -6 Partials 1884 1884 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aadomn commented 3 months ago

@aadomn could you please add unit tests for those two edge cases?

@gsora done :heavy_check_mark:

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud