Closed KaloyanTanev closed 2 months ago
Attention: Patch coverage is 76.38889%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 57.64%. Comparing base (
92ce181
) to head (5b6e22f
).
Files with missing lines | Patch % | Lines |
---|---|---|
cmd/exit_sign.go | 76.38% | 12 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Refactor exits logic. There is no change in the logic anywhere. The main differences are:
ExpertMode
is renamed toSkipBeaconNodeCheck
as this is essentially what it doesIf others agree, I'm in favour of completely removing the
SkipBeaconNodeCheck
config, as it is unnecessary.category: refactor ticket: none