ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client
https://docs.obol.tech/
Other
202 stars 90 forks source link

core/validatorapi: check proposal data against consensus one #3292

Closed gsora closed 1 month ago

gsora commented 2 months ago

Instead of blindly accepting VC proposal data, check it for integrity against what we have in DutyDB: if they differ, stop the process.

category: refactor ticket: none

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 53.77358% with 49 lines in your changes missing coverage. Please review.

Project coverage is 57.70%. Comparing base (c835711) to head (b5ef635). Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
core/validatorapi/validatorapi.go 52.42% 39 Missing and 10 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3292 +/- ## ========================================== + Coverage 57.63% 57.70% +0.06% ========================================== Files 211 211 Lines 30480 30718 +238 ========================================== + Hits 17568 17726 +158 - Misses 11016 11077 +61 - Partials 1896 1915 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gsora commented 2 months ago

Tested in kurtosis, seems to be working well.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud