ObolNetwork / charon

Charon (pronounced 'kharon') is a Proof of Stake Ethereum Distributed Validator Client
https://docs.obol.tech/
Other
202 stars 90 forks source link

*: consensus abstraction #3327

Closed pinebit closed 3 weeks ago

pinebit commented 1 month ago

Summary of changes:

  1. Introduced & implemented ConsensusController interface.
  2. Refactored the entire consensus package with increased test coverage.
  3. Added cluster run --consensus-protocol=xyz flag.
  4. Wired Priority protocol to change the current core consensus algorithm.
  5. Support to run two consensus protocols at a time (one for Priority - QBFT and another is for Core).
  6. Added docs/consensus.md

category: feature ticket: #3304

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 74.13333% with 97 lines in your changes missing coverage. Please review.

Project coverage is 58.82%. Comparing base (774902f) to head (078de38). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
app/app.go 0.00% 41 Missing :warning:
core/consensus/controller.go 67.44% 10 Missing and 4 partials :warning:
core/consensus/qbft/qbft.go 76.36% 12 Missing and 1 partial :warning:
core/corepb/v1/consensus.pb.go 40.00% 9 Missing :warning:
core/consensus/qbft/transport.go 73.07% 7 Missing :warning:
core/consensus/qbft/msg.go 70.00% 6 Missing :warning:
cluster/manifestpb/v1/manifest.pb.go 0.00% 5 Missing :warning:
core/deadline.go 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3327 +/- ## ========================================== + Coverage 58.68% 58.82% +0.14% ========================================== Files 210 216 +6 Lines 30290 30449 +159 ========================================== + Hits 17777 17913 +136 - Misses 10621 10636 +15 - Partials 1892 1900 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pinebit commented 1 month ago

Added @OisinKyne to review at least:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarCloud