Upstream obisidian sample plugin removed rollupjs and started using ESBuild

ObsidianToAnki / Obsidian_to_Anki

Script to add flashcards from text/markdown files to Anki

GNU General Public License v3.0

1.44k stars 128 forks source link

Upstream obisidian sample plugin removed rollupjs and started using ESBuild #496

Open ShootingKing-AM opened 6 months ago

ShootingKing-AM commented 6 months ago

have to use recommended build mode, may break in future - Starting from https://github.com/obsidianmd/obsidian-sample-plugin/commit/3afc9d78ab809784d8ccf6d17e94c1509330e217
Also relates to https://github.com/Pseudonium/Obsidian_to_Anki/pull/366

mattcoleanderson commented 5 months ago

Just my 2 cents. I don't see a reason to change the build tool just because the sample plugin opted for a different tool.

All build tools are different way of doing the same thing. So the choice of tool is an opinion. There is no reason to believe this change in the sample plugin could result in a breaking change.

ShootingKing-AM commented 5 months ago

I am not an expert on the matter but I don't think it costs us anything to follow the obsidian developer's recommendation.

mattcoleanderson commented 5 months ago

Just my thoughts. It will cost something. It will cost time and effort to implement and learn a new build tool. In my opinion, their choice to change isn't really a recommendation so much as an opinionated choice by the developer who made the commit. It's highly likely they just prefer esbuild because they are familiar with it. But there really is no benefit between the two.

That said, if you prefer esbuild, then by all means change it. But I believe it's preference not necessity.