search

Ocean-Data-Lab / ooipy

Python library and demo code for processing and visualization of data from Ocean Observatories Initiative (OOI)
https://ooipy.readthedocs.io/en/latest/
MIT License
15 stars 8 forks source link

Default to always using multiprocessing for spectrogram and psd calculation #146

Open John-Ragland opened 1 year ago

John-Ragland commented 1 year ago

It looks like compute_spectrogram_mp and compute_psd_mp work as expected. We can create a single compute_spectrogram method that has multiprocessing as parameter. I'll wait to work on this until after we merge the xarray changes.

John-Ragland commented 1 year ago

Actually, after looking at this a bit further it works, but there are some quirks that might require a little more work. @anishdixit-uw do you think we should do this for 1.2.0 release or save it for later?

anishdixit-uw commented 1 year ago

The current changes for spectrogram and psd function are ready, so maybe we can run through what extra changes we need for this issue once and then finalize? @John-Ragland